Skip to content

fix(bundler-plugins): upload literal artifact paths - #25356

Merged
msonnb merged 3 commits into
getsentry:developfrom
jpdefo:feat/literal-sourcemap-paths
Nov 3, 2026
Merged

msonnb merged 3 commits into
getsentry:developfrom
jpdefo:feat/literal-sourcemap-paths

Conversation

@jpdefo

@jpdefo jpdefo commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Treat detected build artifact paths as literal filenames when selecting source maps for upload. This keeps Nitro chunks such as _libs/_sentry/node+[...].mjs in the upload set while preserving user-provided asset and ignore globs. The Nuxt source-map assertions now require these chunks to be uploaded.

On Windows, eight existing path assertions and the CLI contract suite's cleanup also fail with unmodified code.

Fixes #25321

@github-actions github-actions Bot added the external PR from an external contributor label Oct 14, 2026
@jpdefo
jpdefo marked this pull request as ready for review October 14, 2026 08:50
Refresh against develop and retain the current shared Nuxt source-map assertions while removing the glob-character upload exception.

Co-authored-by: Codex <codex@openai.com>
@jpdefo
jpdefo force-pushed the feat/literal-sourcemap-paths branch from 5ed99e6 to 1bafc55 Compare October 30, 2026 05:40
@jpdefo
jpdefo requested review from a team as code owners October 30, 2026 05:40
@jpdefo
jpdefo requested review from andreiborza, chargome, isaacs, logaretm, msonnb and nicohrubec and removed request for a team October 30, 2026 05:40
@msonnb msonnb self-assigned this Nov 3, 2026

@msonnb msonnb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@msonnb
msonnb merged commit 541a0d4 into getsentry:develop Nov 3, 2026
258 checks passed
andreiborza pushed a commit that referenced this pull request Nov 3, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #25356

Co-authored-by: msonnb <26038247+msonnb@users.noreply.github.com>
@jpdefo
jpdefo deleted the feat/literal-sourcemap-paths branch November 5, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external PR from an external contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(bundler-plugins): Files with glob characters in their path are not uploaded

2 participants